Skip to content

docs(ci): replace hardcoded versions with config files#480

Merged
Hyperkid123 merged 2 commits intoRedHatInsights:mainfrom
charlesmulder:RHCLOUD-47389
Apr 30, 2026
Merged

docs(ci): replace hardcoded versions with config files#480
Hyperkid123 merged 2 commits intoRedHatInsights:mainfrom
charlesmulder:RHCLOUD-47389

Conversation

@charlesmulder
Copy link
Copy Markdown
Contributor

@charlesmulder charlesmulder commented Apr 30, 2026

Description

Established single source of truth for runtime versions (Node, Java, npm) by creating .java-version and updating all documentation and CI workflows to reference config files instead of hardcoded version numbers.

Problem: Docs and CI contained hardcoded versions (Node 20.19.5, Java 21, npm 11.6.2) that go stale.

Solution:

  • Created .java-version with 21
  • Updated all docs to reference .nvmrc / .java-version / package.json instead of hardcoded versions
  • Enhanced setup-environment action to read .java-version and setup Java automatically
  • Removed hardcoded npm upgrade (Node 24 ships with npm 11.x)

RHCLOUD-47389


How to test locally

  1. Verify .java-version and .nvmrc exist:

    cat .java-version  # Should show: 21                                                                                                                                    
    cat .nvmrc         # Should show: 24.15.0    
  2. Check docs reference config files (not hardcoded versions):

grep -r "20\.19\.5\|Java 21\|npm 11\.6\.2" *.md CLAUDE.md                                                                                                                  
# Should return no results 
  1. Test CI action locally (if using act):
act -j install
# Should setup Java 21 from .java-version and Node from .nvmrc
  1. Verify Maven build works:
npm install
ls -lh target/*.jar  # Should show generator JAR built

Anything reviewers should know?

  • No functional changes to code generation or builds
  • CI workflows (ci.yml, sync-apis.yml) both use setup-environment action, which now handles Java setup
  • npm upgrade step removed from setup-environment because Node 24 ships with npm 11.x (current: 11.12.1)
  • .java-version follows standard used by jEnv, asdf, and other version managers

Checklist

  • Tests: N/A (documentation/CI only)
  • API: N/A (no API changes)
  • Migrations: N/A (no schema changes)
  • Dependencies: no impact to services (version files are build-time only)
  • Security: N/A (no security-sensitive code)

AI disclosure

Assisted by: Claude Code

@charlesmulder charlesmulder marked this pull request as draft April 30, 2026 10:28
@charlesmulder charlesmulder marked this pull request as ready for review April 30, 2026 10:41
@Hyperkid123 Hyperkid123 merged commit d48b15c into RedHatInsights:main Apr 30, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants